Add events section to hackathons #7316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoek1
requested review from
danlipert,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
octavioamu
suggested changes
Sep 9, 2020
app/dashboard/views.py
Outdated
|
|
||
|
|
||
| def events(request, hackathon): | ||
| hackathon_event = get_object_or_404(HackathonEvent, id=hackathon) |
There was a problem hiding this comment.
as this seems to be a Rest endpoint with json answers lets keep the server answers to rest json payloads. In that way we can be sure the reason why failing is actually a not found event.
PixelantDesign
approved these changes
Sep 14, 2020
frankchen07
approved these changes
Sep 14, 2020
|
also, do we have GA impression tracking for the event page? |
|
@zoek1 Could you get travis to go green ? |
|
The only problem is the ipfs version, but i didn't touch such code 🤔 |
thelostone-mc
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://www.loom.com/share/a82ef2081ffb45e6bef233fe9214112d
Refers/Fixes
#6695
Testing